Skip to content

Validate if GraphQL Context exists for another Execution Contexts - #26

Open
dantehemerson wants to merge 1 commit into
krislefeber:masterfrom
dantecalderon:fix/validate-gql-execution-ctx
Open

Validate if GraphQL Context exists for another Execution Contexts#26
dantehemerson wants to merge 1 commit into
krislefeber:masterfrom
dantecalderon:fix/validate-gql-execution-ctx

Conversation

@dantehemerson

Copy link
Copy Markdown
Contributor

Fix #22
Since the interceptor is injecting globally, we must validate that the GraphQL context exists.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 106805450

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 106805450

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

@hamxabaig

Copy link
Copy Markdown

@krislefeber can you please merge it? It's happening to us as well. We are not able to move fwd. By the way, love the package & thanks for all the effort 🎉

@hamxabaig hamxabaig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@junaidcs

Copy link
Copy Markdown

Screenshot 2020-10-14 at 11 38 46 AM

@krislefeber getting error due to this, please merge this PR. Thanks

@junaidcs junaidcs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinhnguyen1211

Copy link
Copy Markdown

Let's merge it

@sujamess sujamess left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Please merge this

@dantehemerson

Copy link
Copy Markdown
Contributor Author

Hi folks. Seems that this repository has not been maintained for a long time. So in the meantime, I have created a new repository to add this feature.

The fix version is: https://github.com/dantehemerson/nestjs-dataloader/releases/tag/v1.0.1
Npm Package: https://www.npmjs.com/package/@dantehemerson/nestjs-dataloader
You can install it by doing: npm i @dantehemerson/nestjs-dataloader

@coveralls

coveralls commented Jul 27, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 106805450

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataloader executing in HttpRequest with empty context in NestJSv7

10 participants